brusselopole / Worldopole

Worldopole is a third party extension for RocketMap showing some nice statistics.
MIT License
85 stars 79 forks source link

Add option to disable lures and show raid count on homepage #347

Closed 123FLO321 closed 6 years ago

123FLO321 commented 6 years ago

Description

This PR adds an option to remove all lures visually and adds an option to show active raid count on home page.

Motivation and Context

Preparation for upcoming Monocle PR

How Has This Been Tested?

Local instance and working fine.

Screenshots (if appropriate):

raids

Types of changes

michikrug commented 6 years ago

It's not a good idea to hide lures and show raids when setting an option called "no_lures". It's okay to hide them, but please separate the raids stuff.

123FLO321 commented 6 years ago

@michikrug Separated no_lures and homepage_raids

javisabalete commented 6 years ago

I'll try this PR tomorrow 👍

darkelement1987 commented 6 years ago

Works as intended!

Obihoernchen commented 6 years ago

@michikrug all fine now?

javisabalete commented 6 years ago

works fine

michikrug commented 6 years ago

@Obihoernchen not tested yet

Obihoernchen commented 6 years ago

looks fine to me. One more tester and I'll merge.