search

brutaldev / StrongNameSigner

Strong-name sign third party .NET assemblies without the source code.
https://brutaldev.com/post/net-assembly-strong-name-signer
Other
327 stars 68 forks source link

New Variable to locate StrongNameSigner #36

Closed tomap closed 7 years ago

tomap commented 7 years ago

Hi,

Could you add a new variable here to locate StrongNameSigner? Here: https://github.com/brutaldev/StrongNameSigner/blob/master/src/Brutal.Dev.StrongNameSigner/StrongNameSigner.targets#L20

You could declare <StrongNameSignerDirectory>$(MSBuildThisFileDirectory)</StrongNameSignerDirectory>

So that from pre / post build step, we can use this variable to find Brutal.Dev.StrongNameSigner console and not hardcode the path containing the version (curerntly Brutal.Dev.StrongNameSigner.2.1.2)

Thank you

brutaldev commented 7 years ago

Hey @tomap I wouldn't even know where to start or how to test that. My MSBuild skills are sketchy at best so if you could submit a PR with an example of how to make use of it I'll happily accept and release another build.

tomap commented 7 years ago

Done, see https://github.com/brutaldev/StrongNameSigner/pull/37

brutaldev commented 7 years ago

Awesome, thanks! Just did some reading and that's pretty useful, it is a pain updating the version each time for me as well so I'll make use this... Will merge and release in a couple of hours when I get back on my dev machine.

brutaldev commented 7 years ago

Released the changes: https://github.com/brutaldev/StrongNameSigner/releases/tag/v2.1.3