search

brutaldev / StrongNameSigner

Strong-name sign third party .NET assemblies without the source code.
https://brutaldev.com/post/net-assembly-strong-name-signer
Other
328 stars 68 forks source link

Added some fixes to version 2.7.0 to further improve performance #58

Closed programatix closed 4 years ago

programatix commented 4 years ago

This is related to https://github.com/brutaldev/StrongNameSigner/issues/57.

Version 2.7.0 doesn't fix the issue I'm having. Checking the msbuild binary log, it seems that there is another path of Microsoft Framework assemblies that are being processed which it should not (as intended by the update done to version 2.7.0). I added the path to the exclude list.

Also I noted that assemblies that are originally signed being processed again and again by StrongNameSigner. This update removed them from being processed.

brutaldev commented 4 years ago

For more context, you need to check if it actually got signed to decide whether the original path needs to be used or the resulting signed path. Going to look at your logs and determine the best way to change this.

brutaldev commented 4 years ago

Added additional paths based on this for different types of projects. Reverted the processed files change, they are already stored in signed which only need friend assembly fixes, all processed references (signed already or not) should be checked for cross-references to the dependencies otherwise new files being reference in the same library fail.