search

brutasse / django-ratelimit-backend

Rate-limit your login attempts at the authentication backend level
https://django-ratelimit-backend.readthedocs.io
BSD 3-Clause "New" or "Revised" License
169 stars 34 forks source link

Support authentication backends that don't have usernames #34

Closed scjody closed 7 years ago

scjody commented 7 years ago

Fixes #31, includes tests.

scjody commented 7 years ago

@brutasse This is ready to go. Please let me know what you think!

scjody commented 7 years ago

@brutasse Thanks for the review! Your change sounds good so I made it.

scjody commented 7 years ago

@brutasse Do you have any idea why the build is failing? The error is:

ERROR: InterpreterNotFound: python3.3

I haven't made any changes that would impact this, and my initial PR about a week ago passed CI.

scjody commented 7 years ago

@brutasse I rebased on your master and CI passes now. I think this is ready to merge but please let me know if you would like any more changes.

brutasse commented 7 years ago

Great, thanks @scjody! Sorry for the silence on the build issue… I didn't know 3.3 now has to be pulled manually.

brutasse commented 7 years ago

@scjody version 1.2 is up on PyPI with these changes.