search

brutasse / django-ratelimit-backend

Rate-limit your login attempts at the authentication backend level
https://django-ratelimit-backend.readthedocs.io
BSD 3-Clause "New" or "Revised" License
169 stars 34 forks source link

Is this still being maintained? #53

Open jmbowman opened 3 years ago

jmbowman commented 3 years ago

It looks like there haven't been any commits in 20 months, and there are a few reasonable-looking PRs that haven't received any reply. @brutasse , are you still maintaining this repository? If not, are you open to handing over to a new maintainer and/or helping facilitate a clean transition to a new fork?

Asking because I'm currently using a fork that we had hoped would be temporary, but are now looking at needing to update it for new Django versions, CI improvements, etc. (and our last submitted PR is among the ones awaiting a reply).

brutasse commented 3 years ago

@jmbowman thanks, indeed I'm happy to transfer ownership to a maintained fork. Is the EDX fork the one you're referring to?

jmbowman commented 3 years ago

Yes; I just kicked off an internal conversation about potentially adopting this, hoping to have a consensus on it by next week. That'll also give some time for anybody currently using another fork to chime in with any suggestions or questions.

brutasse commented 3 years ago

Thanks!

jmbowman commented 3 years ago

We learned a lot from that internal conversation! I'll link to our findings and subsequent code changes, as they may be useful to other users of this package:

Basically, we found out that our login rate limiting in that service was a confusing pile of overlapping implementations. At least for our use case, django-ratelimit covers what we need (and was already in use for other URLs), so I'm afraid we'll be dropping our fork of this package. The notes above may help serve as a migration path for others.

brutasse commented 3 years ago

Thanks @jmbowman, interesting read :+1: