brutasse / graphite-cyanite

A plugin for using graphite-web with the cassandra-based Cyanite storage backend.
BSD 3-Clause "New" or "Revised" License
85 stars 21 forks source link

Typo in cyanite.py #1

Closed daledude closed 10 years ago

daledude commented 10 years ago

Line 64 has settings.CYANITE_URL when it should be settings.CYANITE_URLS

brutasse commented 10 years ago

I don't see a typo. There are two supported syntaxes for single-host and multiple-host installations:

CYANITE_URL = 'http://host:port'
CYANITE_URLS = [
    'http://host1:port',
    'http://host2:port',
]

Besides that code isn't line 64 anymore. Did you have an actual issue while configuring cyanite for graphite-web? Feel free to reopen if that's the case.

daledude commented 10 years ago

Ok, since yesterday, the line is now 70.

urls = getattr(settings, 'CYANITE_URLS', [settings.CYANITE_URL])

Following the README I used CYANITE_URLS which produces the error:

Traceback (most recent call last):
  File "/usr/lib64/python2.6/site-packages/django/core/handlers/base.py", line 101, in get_response
    resolver_match = resolver.resolve(request.path_info)
  File "/usr/lib64/python2.6/site-packages/django/core/urlresolvers.py", line 320, in resolve
    sub_match = pattern.resolve(new_path)
  File "/usr/lib64/python2.6/site-packages/django/core/urlresolvers.py", line 320, in resolve
    sub_match = pattern.resolve(new_path)
  File "/usr/lib64/python2.6/site-packages/django/core/urlresolvers.py", line 222, in resolve
    return ResolverMatch(self.callback, args, kwargs, self.name)
  File "/usr/lib64/python2.6/site-packages/django/core/urlresolvers.py", line 229, in callback
    self._callback = get_callable(self._callback_str)
  File "/usr/lib64/python2.6/site-packages/django/utils/functional.py", line 32, in wrapper
    result = func(*args)
  File "/usr/lib64/python2.6/site-packages/django/core/urlresolvers.py", line 96, in get_callable
    mod = import_module(mod_name)
  File "/usr/lib64/python2.6/site-packages/django/utils/importlib.py", line 40, in import_module
    __import__(name)
  File "/opt/graphite/webapp/graphite/render/views.py", line 34, in <module>
    from graphite.render.evaluator import evaluateTarget
  File "/opt/graphite/webapp/graphite/render/evaluator.py", line 5, in <module>
    from graphite.render.datalib import fetchData, TimeSeries
  File "/opt/graphite/webapp/graphite/render/datalib.py", line 18, in <module>
    from graphite.storage import STORE
  File "/opt/graphite/webapp/graphite/storage.py", line 165, in <module>
    STORE = Store()
  File "/opt/graphite/webapp/graphite/storage.py", line 27, in __init__
    for finder_path in settings.STORAGE_FINDERS]
  File "/opt/graphite/webapp/graphite/storage.py", line 20, in get_finder
    return getattr(module, class_name)()
  File "/usr/lib/python2.6/site-packages/cyanite.py", line 70, in __init__
    urls = getattr(settings, 'CYANITE_URLS', [settings.CYANITE_URL])
  File "/usr/lib64/python2.6/site-packages/django/conf/__init__.py", line 55, in __getattr__
    return getattr(self._wrapped, name)
AttributeError: 'Settings' object has no attribute 'CYANITE_URL'
brutasse commented 10 years ago

Can you paste your settings? For some reason it doesn't seem to contain any of CYANITE_URLS or CYANITE_URL. That could also be an import issue with your graphite settings…

brutasse commented 10 years ago

Oh wait no I'm an idiot.

brutasse commented 10 years ago

Ok. Try with the latest version (0.4.2), it should work now :)