search

brutella / dnssd

This library implements Multicast DNS (mDNS) and DNS-Based Service Discovery (DNS-SD) for Zero Configuration Networking in Go.
MIT License
207 stars 33 forks source link

The list of key/value will always be sorted by the key name #12

Closed ErwanMAS closed 4 years ago

ErwanMAS commented 5 years ago

in dns.go https://github.com/brutella/dnssd/blob/61d1bc6e53ace5b3d9ecb46ffd0b3158c00ae9d0/dns.go#L190 , the result of remove is not deterministic for TXT rr

When we build the array Txt , we fill up by sorting by keys .

ErwanMAS commented 5 years ago

Travis-ci job is now fixed on linux .

ErwanMAS commented 5 years ago

@brutella do you have time to merge this request ?

brutella commented 4 years ago

Thanks for your PR.