brutella / hc

hc is a lightweight framework to develop HomeKit accessories in Go.
Apache License 2.0
1.74k stars 189 forks source link

github.com/agl/ed25519 repo is dead #167

Closed e1z0 closed 4 years ago

e1z0 commented 4 years ago

4 days ago the repository was moved...

../go/src/github.com/brutella/hc/crypto/ed25519.go:5:2: no Go files in /root/go/src/github.com/agl/ed25519

It moved to https://godoc.org/golang.org/x/crypto/ed25519

But it does not compile either, maybe some functions or calls are incompatible :)

worepix commented 4 years ago

There will be little code change, it is not just repository move. When I tried to change repository how documentation says. Some type errors just appeared.

# github.com/brutella/hc/crypto
../../../go/src/github.com/brutella/hc/crypto/ed25519.go:21:24: cannot use &k (type *[32]byte) as type "crypto/ed25519".PublicKey in argument to "golang.org/x/crypto/ed25519".Verify
../../../go/src/github.com/brutella/hc/crypto/ed25519.go:21:34: cannot use &s (type *[64]byte) as type []byte in argument to "golang.org/x/crypto/ed25519".Verify
../../../go/src/github.com/brutella/hc/crypto/ed25519.go:32:28: cannot use &k (type *[64]byte) as type "crypto/ed25519".PrivateKey in argument to "golang.org/x/crypto/ed25519".Sign
marek-memsql commented 4 years ago

The same issue here - I can no longer build... :(

brutella commented 4 years ago

Sorry for this to take so long.

FYI: Go 1.13 is now required with this change.