search

brutella / hkcam

Open-Source HomeKit Surveillance Camera
https://hochgatterer.me/hkcam/
Apache License 2.0
920 stars 141 forks source link

Added support for RTSP #115

Closed bartekpacia closed 1 year ago

bartekpacia commented 3 years ago

I'm making a PR for changes made by @e1z0 in his issue.

It works really great

bartekpacia commented 2 years ago

please @brutella, review this

bartekpacia commented 2 years ago

: (

brutella commented 2 years ago

Sorry for not looking into this so far. Your pull request results in a lot of duplicated code. It would be great if we could fix that.

Could you please summarise which FFmpeg options have to be changed to make RTSP work. Thanks.

tomtastic commented 1 year ago

Hi @bartekpacia, will you have time to resolve these questions, I'd love to see your work merged here :)

bartekpacia commented 1 year ago

Hahah, I totally forgot about this PR. Will look today into it.

bartekpacia commented 1 year ago

Actually what I did in this PR is only apply a patch from @e1z0 that he shared in this issue. I didn't write this code myself. Also, I see that some merge conflicts arose.

@tomtastic Feel free to pick up this PR and create a new one.