search

brutella / hkcam

Open-Source HomeKit Surveillance Camera
https://hochgatterer.me/hkcam/
Apache License 2.0
925 stars 141 forks source link

UI corners of Snapshot #39

Closed mgoeller closed 5 years ago

mgoeller commented 5 years ago

The Snapshot should be cut to the correct resolution (according to Apple HomeKit certifications) so the corners are round (see left camera) and not edged (right camera). Actually this should be done with ffmpeg and resizing the video as well, because after opening and closing the live stream it will take the last image of the live stream as snapshot which is in this case "too big as well" and shows edged. This takes however a lot of resources, probably not very suitable for the Raspberry Pi Zero. Screenshot 2019-06-24 at 13 01 23

brutella commented 5 years ago

The masking of the corners is done the Home app. There is no indication of rounded corners in the HAP specification.

mgoeller commented 5 years ago

Correct, but the Home App is only masking the corners if the scale of the snapshot if the ratio is correct. The current 480x360 resolution of the snapshots is not officially accepted and results therefore in the UI error with the edged corners. The correct screenshots are produced when I edit the ffmpeg command to "-scale=1280:720". IMG_0871 IMG_0870 snapshot_2019-06-24T15:50:59+01:00 snapshot_2019-06-24T15:37:09+01:00