search

bruth / django-tracking2

django-tracking2 tracks the length of time visitors and registered users spend on your site. Although this will work for websites, this is more applicable to web _applications_ with registered users. This does not replace (nor intend) to replace client-side analytics which is great for understanding aggregate flow of page views.
BSD 2-Clause "Simplified" License
205 stars 67 forks source link

Add Django 2.0 support #73

Closed tpeaton closed 6 years ago

tpeaton commented 6 years ago

This adds support for Django 2.0. Django 2.1 isn't supported at the moment because of a bug involving the model permissions in the existing migration in this app.

bruth commented 6 years ago

This looks great to me. @mjschultz Any comments you have on this?

mjschultz commented 6 years ago

Yeah, it looks good to me. I think we'll want to start dropping support for older djangos (and pythons), my general preference is to just support what django supports.

That said, changing those things could be a can of worms in the PR so we should probably push it off to a follow-up.

tpeaton commented 6 years ago

My next stop is with the django folks to see what they want to do about fixing the permissions bug (that I haven't yet filed). It's likely we'll need some changes in this app to fix the problem. If that ends up being the case, I'll create a PR for that as well as adding/removing new/old python/django versions.