search

bruth / synapse

Hooks to support data binding between virtually any object.
http://bruth.github.com/synapse/docs/
BSD 2-Clause "Simplified" License
150 stars 6 forks source link

triggerOnBind in defaultConnectOptions #17

Closed erikschoel closed 12 years ago

erikschoel commented 12 years ago

Hey Byron,

Before anything else: Great work!!

I ran into one little issue related to triggerOnBind as one of the defaultConnectOptions. The default is true, and I noticed that explicitly specifying false wasn't working.

That's because you later test whether the option is provided using - if (!options[key]) - and a value of false evaluates to false causing the default not to be overwritten.

For my purpose I just changed the default into false overriding with true if I need to, but this should be fixed more elegantly.

Can you add this to the next release?

Thanks!! And best regards,

Erik

bruth commented 12 years ago

Thanks for the feedback and finding. I will fix it shortly.