search

brutusin / json-forms

JSON Schema to HTML form generator, supporting dynamic subschemas (on the fly resolution). Extensible and customizable library with zero dependencies. Bootstrap add-ons provided
http://brutusin.org/json-forms
Apache License 2.0
606 stars 168 forks source link

Issue on dynamic Schema in arrays #106

Closed KiSchulte closed 6 years ago

KiSchulte commented 6 years ago

I tried to integrate a dynamic schema on an array property and wasn't successful. Was breaking at this line. Seems that there is a prototype for equals() missing, as the error was equals() is not a function. I'm not sure why this function is necessary here, or what the prototype function was. I exchanged the line by if (element === "#") { which is working fine.

https://github.com/brutusin/json-forms/blob/fcd15f14a7e97003efb12a6b70856c8c582a077b/src/js/brutusin-json-forms.js#L1416

KiSchulte commented 6 years ago

Sorry I just have seen that there is already a PullRequest for that. https://github.com/brutusin/json-forms/pull/101

I simply didn't have a look there before, and the issue didn't pop up in the issue list.