brutusin / json-forms

JSON Schema to HTML form generator, supporting dynamic subschemas (on the fly resolution). Extensible and customizable library with zero dependencies. Bootstrap add-ons provided
http://brutusin.org/json-forms
Apache License 2.0
606 stars 168 forks source link

Unnecessary eval prevents execution in CSP environment #121

Open JamesCullum opened 6 years ago

JamesCullum commented 6 years ago

The script uses the command eval in line 1242. As far as I can see, this command is useless, as there are no other variables that require this function.

However, usage of the eval command collides with Content-Security-Policies. Those usually deny this command and will block of the data insertation. Allowing this command will allow it everywhere and contradicts the purpose of CSP.

Minor changes in the following PR will remove this command and allows it to run successfully in a CSP controlled environment.