brutusin / json-forms

JSON Schema to HTML form generator, supporting dynamic subschemas (on the fly resolution). Extensible and customizable library with zero dependencies. Bootstrap add-ons provided
http://brutusin.org/json-forms
Apache License 2.0
607 stars 168 forks source link

Little bug #88

Closed fabifabi closed 7 years ago

fabifabi commented 7 years ago

line 177: if (s.media) { input = document.createElement("input"); input.type = "file"; appendChild(container, input, s); // XXX TODO, encode the SOB properly. }

fabifabi commented 7 years ago

line 345: if (s.required) { input = document.createElement("input"); input.type = "checkbox"; if (value === true) { input.checked = true; } else if (s.default !== undefined) { input.checked = s.default; } }

fabifabi commented 7 years ago

line 753: addButton.className = "addItem"; I need this for know where it is on the form. as it ,i cna customize the table edition (i put up/down as a decorator, so i can move my item in the table)

idelvall commented 7 years ago

thanks @fabifabi

fabifabi commented 7 years ago

Hello!

I added "up" and "down" button to array renderer.As it u can move up&down your item,that's can be usefull (at least for me,lol)... I will do the decorator for bootstrap. My (little) problem: I am very bad for git :) so i do'nt know how to post it for you..... As it is arround 40 lines,can i post it here ? Or can i have an email to post it ?

Thanks a lot,i love your work,men !

idelvall commented 7 years ago

:) you should definitely invest some time in learning git basics, it's worth it. You can create a fiddle to share the code and at the same time show this new feature. Thanks @fabifabi you rock!

fabifabi commented 7 years ago

I am using GIT but i dont know how that's work with github :) the bootstrap is done also....i will try do a branch for show you it, i think it is bug free....and it is mroe hard to do with decorator than inside the original source......okay,let's me try this {#|[{#|{[ git :)

fabifabi commented 7 years ago

my demo : http://www.pigere.com/demojson/

The source are not minify,so u can take :)

I tried to publish on github,but i am fear to publish all my git...and i am not in mood to read all tutotiral for today,sorry, kinda lazy for learn tool.i prefer code more than learn it hahaha!

fabifabi commented 7 years ago

ho i forgot my sample is in french,so for see how that's work on a normal example, go "liste menbre" panel,try add (you add people),and move them up&down&remove. thanks,hope thats' help a bit for this fantastic library.

idelvall commented 7 years ago

Yes I see, that is a useful feature. I will include it in the version 2 of the library I am currently working on. I will let you know when it is ready. Regarding the current version, I will wait for your pull request (I am trying to motivate you learn the github way ;) ) Cheers

fabifabi commented 7 years ago

i hate this kind of tool :( i have to watch it,but i am very busy for now.....i try push your library until its limit haha !

fabifabi commented 7 years ago

btw,what is new to v2 ???? i don't want do stuff thats' will exist soon :)

idelvall commented 7 years ago

it's conceptually the same, but the code is well modularized and easier to maintain and extend.