bruvellu / cifonauta

Marine biology image database by CEBIMar/USP
http://cifonauta.cebimar.usp.br
GNU General Public License v3.0
21 stars 5 forks source link

Refactor curation queries #343

Open bruvellu opened 1 month ago

bruvellu commented 1 month ago

Updating curations for every taxon update is complex. The signals we set up are not handling well all the edge cases. Perhaps a simpler way is, instead of setting the curation relationship to every taxon, simply fetch curations from the ancestors. In this way, we don't need to handle the high burden of updating at every transaction.

This issue will attempt to solve the above and address #341. But before, there's a log of cleaning up to do. Mainly, moving the logic for taxon update, media synchronization, and curation update to Taxon methods. This is also a first step towards reducing the 6 redundant copies of the code in the views upload_media_step2, editing_media_details, editing_media_list, my_media_details, revision_media_details, my_curations_media_details.

bruvellu commented 3 weeks ago

The cleaning up is done with 3a4ecd27b89ddfbb81fd15f0392650958245aa43. This actually closes #341.

Now I need to find all the places where curations are being queried from Taxon and Media and update the logic to fetch all curations from the ancestors.

But I'll already merge the branch to develop to already push this code to staging for testing.