bruvzg / gdsdecomp

Godot reverse engineering tools
MIT License
1.34k stars 134 forks source link

does not support high dpi display scaling #138

Open JC3 opened 11 months ago

JC3 commented 11 months ago

System information

windows 10, system scaler at 250%

Issue description

on high dpi displays (with system scaler != 100%), the ui is too small.

Steps to reproduce

No response

Recovery log

n/a

Minimal reproduction project

No response

nikitalita commented 11 months ago

I'll have to take a look if Godot supports UI scaling like this. I haven't messed with the UI that much.

JC3 commented 11 months ago

I'm pretty sure it does; I'm not familiar with Godot at all but there is a game I play (Virtual Circuit Board) that is written in Godot and does have high DPI scaling support.

Fwiw.

Thanks for looking into it!

On Tue, Jul 18, 2023 at 4:39 AM nikitalita @.***> wrote:

I'll have to take a look if Godot supports UI scaling like this. I haven't messed with the UI that much.

— Reply to this email directly, view it on GitHub https://github.com/bruvzg/gdsdecomp/issues/138#issuecomment-1639777583, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLDV4C4I5MJRSY7RYFRR3LXQZDUJANCNFSM6AAAAAA2LIJPTE . You are receiving this because you authored the thread.Message ID: @.***>

nikitalita commented 11 months ago

Looking into it, the DPI scaling support built-in to Godot is pretty bad for control elements, and is worse if the GUI is in C++. We're going to need to re-engineer the UI first, see #130