bruvzg / gdsdecomp

Godot reverse engineering tools
MIT License
1.42k stars 138 forks source link

GDCs not converted when using CLI project export on windows #48

Closed The-ThirtyFour closed 2 years ago

The-ThirtyFour commented 2 years ago

title. I don't know if this is a windows problem or gdsdecomp's None gdc where converted to gd, and they aren't encrypted

nikitalita commented 2 years ago

could you post the game you were trying to extract and the CLI command that you used?

The-ThirtyFour commented 2 years ago

it was a godot 3.4 game the export command returned that is an unknown version so, as far i can tell, it is unimplemented i've managed to edit the standalone to recognize it somehow, and it worked (maybe there's some error, but i didn't found yet)

nikitalita commented 2 years ago

it was a godot 3.4 game the export command returned that is an unknown version so, as far i can tell, it is unimplemented i've managed to edit the standalone to recognize it somehow, and it worked (maybe there's some error, but i didn't found yet)

wait, what? Can you PR your changes?

The-ThirtyFour commented 2 years ago

it was a simple edit just copied

elif version.begins_with("3.3"):
decomp = GDScriptDecomp_5565f55.new()

and changed to 3.4 i wasn't expecting it to work