bruvzg / gdsdecomp

Godot reverse engineering tools
MIT License
1.42k stars 138 forks source link

Standalone: Fix icon display, disable embedded windows, disable binary export, fix CI #54

Closed nikitalita closed 2 years ago

nikitalita commented 2 years ago

We were previously importing all the Editor icons into the theme resource to load the icons in the standalone binary; Godot 4.x doesn't allow you to import the theme resource by reference any more, so we would have to manually update the theme each time, and it also massively bloats the size of that resource. Instead, we now dynamically generate them and include them in a generated header.

I also disabled binary resource conversion upon export because it is currently broken (see https://github.com/godotengine/godot/pull/56185)

lufog commented 2 years ago

You can also update modules in SCONSFLAGS_TEMPLATE:

Rename module_opensimplex_enabled to module_noise_enabled (godotengine/godot#56718) Delete module_bullet_enabled (godotengine/godot#58946) Delete module_gdnative_enabled (godotengine/godot#58925) Delete module_pvr_enabled (godotengine/godot#56309) Delete module_webm_enabled (godotengine/godot#53833)

It would also be nice to disable Embed Subwindows in standalone. Because this feature does not always work well. For example: image The subwindow cannot be moved because the top of the window is not accessible.