search

bruvzg / gdsdecomp

Godot reverse engineering tools
MIT License
1.42k stars 138 forks source link

Fix decompiling encrypted 3.x scripts #65

Closed polybiusproxy closed 1 year ago

polybiusproxy commented 1 year ago

Fixes #64.

nikitalita commented 1 year ago

Thanks for the PR! Can you try the artifact from the build action to verify that this worked?

polybiusproxy commented 1 year ago

Thanks for the PR! Can you try the artifact from the build action to verify that this worked?

Of course! I will try once I'm free.

polybiusproxy commented 1 year ago

I can confirm the error is gone, however, the scripts (.gde files) didn't decompile. Doing it manually on the UI will return this error: Condition "p_base->get_length() < base + length" is true. Returning: ERR_FILE_CORRUPT.

nikitalita commented 1 year ago

Does this error also occur if you use the --recover option in the CLI to recover the whole project?

polybiusproxy commented 1 year ago

Does this error also occur if you use the --recover option in the CLI to recover the whole project?

Hey, sorry for replying late! Both the CLI and the editor return the same error.

nikitalita commented 1 year ago

Are you able to share the game in question? If you want to do it privately, you can hit me up on the godot discord. I'm Nikita_lita on there.

nikitalita commented 1 year ago

Thanks for the PR! I've added additional commits to fix the issue; I had to add back the v3 version of FileAccessEncrypted to decrypt files as V4 introduced breaking changes.