search

bruxy70 / Holidays

📅 Custom Home Assistant integration for public holidays - also used for garbage_collection integration to automatically move scheduled events that fall on a public holiday (by an automation blueprint)
MIT License
45 stars 12 forks source link

Singapore (SG/SGP) missing in country drop down list #18

Closed sognen closed 2 years ago

sognen commented 2 years ago

Describe the bug

Singapore does not appear in the country dropdown list. I see a long list of other countries in the mentioned dropdown. Singapore is listed on https://github.com/dr-prodigy/python-holidays. I am not sure if this makes it a a feature request or a bug report.

Thanks for this integration.

Configuration

Do you configure the integration in YAML or Config Flow (GUI)? : Integration is configured in gui.

Error log/debug information

Screenshots

Version

Integration version: Latest

Home Assistant version: Latest

OddyAte commented 2 years ago

Hey, I had the same issue but for RO (Romania). I went ahead and with File Editor I modified this file:

/config/custom_components/holidays/const.py

Added "RO" to COUNTRY_CODES list, restarted Home Assistant, changed it in the list and it works fine. You will need to add SG.

sognen commented 2 years ago

@OddyAte Thank you. That worked.