search

bruxy70 / Holidays

📅 Custom Home Assistant integration for public holidays - also used for garbage_collection integration to automatically move scheduled events that fall on a public holiday (by an automation blueprint)
MIT License
44 stars 11 forks source link

Country Code for Ireland - IE - not listed in drop-down, #28

Closed sotatech closed 2 years ago

sotatech commented 2 years ago

Before you submit a new bug report, please check that

Describe the bug

This is a follow up to this issue: https://github.com/home-assistant/core/issues/67542 After upgrading to 2022.3.0 I got an error for this integration that the IE country code is invalid.

I also tried your integration and it does not list the IE country code.

Configuration

I cannot configure your integration as it does not have my country code.

Debug logs

As above.
bruxy70 commented 2 years ago

I see, it is a bug in the holidays library: https://github.com/dr-prodigy/python-holidays/issues/636 Also open bug for Home Assistant core: https://github.com/home-assistant/core/issues/67542 We'll have to wait for the holidays bugfix I suppose. Sorry for that.

bruxy70 commented 2 years ago

The thing is, the library is used in HA core integration for workday. This dictates the version of the library, so I do not really have a choice. Are the Irish holidays very different from Northern Ireland? If not, can you tap to these in the meantime?

sotatech commented 2 years ago

Well it's a different country so yes they are different but I don't know what the difference is! It's no big deal, but I use the workday integration to manage my heating scheduler. For now I will just change the binary_sensor to a helper entity so I can control it manually. Thanks for your help 👍

Sudo-Rob commented 2 years ago

Is this not the file you need? Look at line 26.

https://github.com/dr-prodigy/python-holidays/blob/master/holidays/countries/ireland.py