bruxy70 / Holidays

📅 Custom Home Assistant integration for public holidays - also used for garbage_collection integration to automatically move scheduled events that fall on a public holiday (by an automation blueprint)
MIT License
45 stars 12 forks source link

Canadian Holidays 2022 - Next_Holiday is Boxing Day #40

Closed CaldwellRoad closed 2 years ago

CaldwellRoad commented 2 years ago

Before you submit a new bug report, please check that

Describe the bug

Hello,

Just downloaded this from HACS and implemented without issue - thanks for creating this. Configured for Canada (CA) and sub for NS and using the Observed option. This is showing the Next Holiday as Boxing Day as seen in the attributes list:

image

It appears that the listing is not showing "Christmas Day" only "Christmas Day (Observed) on 27th" and Boxing Day on 26th, but technically Boxing Day (Observed) should be 27th and Christmas Day (Observed) on the 26th - just a weird falling of Holidays this year for logic I believe.

Please let me know if you need any additional details or configs (as this is just the default install) as I am new at creating any bug reports and using GitHub.

Configuration

For some reason - I am unable to download the config from my HA instance... I will update when I get that sorted.

Debug logs

Didn't do any debug logs.
bruxy70 commented 2 years ago

Can you please log this issue with the Holidays package? This helper is just an interface to this package, it does not calculate any of the holidays. Thanks.

CaldwellRoad commented 2 years ago

Sorry about that! I will submit to the proper project.

CaldwellRoad commented 2 years ago

It appears to be fixed in latest version v.0.17.2, but Canada specific fixes and improvements in v.0.17 and v.0.16. Does this package need to get the updated version, or is this something manually I can update?