Closed pawelma closed 1 year ago
This is excellent, thank you. I will test over the weekend. If that works, I'll merge it. I thik if this is consistent with the core component, we might possibly try to make it part of the ESPHome standard integrations...
Thanks. I don't think it suits the standard component since this is a very specific kind of cover, and it would have to be made more generic to merge it. Unless that would be a different type of cover for this specific use case that we have 🤔.
@pawelma I've finally found the time to test it. I put that to a separate branch, so that I can switch between the two in ESPHome (just changing ref between master/test). I'll have to make the changes for the inverted tilt position. Other than that, it seems to work fine. One thing I have noticed is, I do not get position updates whilst the shutter is moving. Is that by design?
Position updates are made but every 1 second AFFAIR. It can be changed I guess, but I wanted to reduce IO as it might make covers less accurate since it's synchronous. Actually, that could be an easy addition to say how often someone wants the position to be updated. The inverted tilt might be annoying for someone who uses current version as it is breaking change and will require some modifications into the automations and control cards.
Hello 👋 . Finally, found some time so raising PR related with issue https://github.com/bruxy70/Venetian-Blinds-Control/issues/5 I raised week ago. I do understand that it does bring breaking changes and changes the philosophy of the current component, so if it doesn't suite this project, feel free to close the PR. I'm just raising for visibility ;).
WHAT
calculation
tilt = tilt + direction_of_travel move tilt_overflow = (tilt-tilt_boundary) direction_of_travel position = position + direction_of_travel * tilt_delta if tilt_overflow > 0