search

brvphoenix / luci-app-wrtbwmon

Bandwidth monitor for OpenWRT
251 stars 53 forks source link

Case insensitive MAC addresses in the Custom User File #21

Closed sinancetinkaya closed 4 years ago

sinancetinkaya commented 4 years ago

Current version doesn't recognize upper case MAC addresses

brvphoenix commented 4 years ago

@sinancetinkaya Have been fixed in 441b0a845b0340e7be1192dc6a8e2314ea6c070d.

Test on this artifact.

sinancetinkaya commented 4 years ago

Tested the ipk file on the artifact link, it's not working. Uppercase MAC addresses don't show up in the list.

Besides, Kiougar's luci-wrtbwmon was pulling the host names from /etc/config/dhcp as well. 

config host
    option dns '1'
    option mac 'XX:XX:XX:XX:XX:XX'
    option ip '192.168.1.2'
    option name 'Sinan-PC'

Wouldn't be this a better approach?

brvphoenix commented 4 years ago

Current pre-released ipk is case insensitive in the custom user file. I have tested lower case, upper case and mixed case and erverthing is OK. You'd better provide more info for debuging.

The dhcp is pulled from luci-rpc and it depends on the upstream OpenWrt whether it can be resolved from /etc/config/dhcp.

sinancetinkaya commented 4 years ago

The link of ipk you gave me is correct, right? Because I tried uppercase Mac address and it didn't show up in the traffic tab.

On Tue, 16 Jun 2020, 05:22 Van Waholtz, notifications@github.com wrote:

Current pre-released ipk is case insensitive in the custom user file. I have tested lower case, upper case and mixed case and erverthing is OK.

The dhcp is pulled from luci-rpc and it depends on the upstream OpenWrt whether it can be resolved from /etc/config/dhcp.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/brvphoenix/luci-app-wrtbwmon/issues/21#issuecomment-644490878, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAUNHR6BXTNLDATU4GAPP23RW3JNLANCNFSM4N5TXPRQ .

brvphoenix commented 4 years ago

https://github.com/brvphoenix/luci-app-wrtbwmon/releases/download/release-2.0.3/luci-app-wrtbwmon_2.0.3-1_all.ipk

sinancetinkaya commented 4 years ago

image image image

sinancetinkaya commented 4 years ago

OpenWrt SNAPSHOT r13573-03a0b7b7e5 / LuCI Master git-20.154.54590-05f07e5

brvphoenix commented 4 years ago

Test to cler the cache. If you are using chrome, press F12, check Disable cache and refresh the page. screenshot

sinancetinkaya commented 4 years ago

Wait a minute, did some change in config options and saved. After that, the host name appeared. luci-app-wrtbwmon requires a restart after custom user file is changed?

brvphoenix commented 4 years ago

@brvphoenix I'm using Firefox, disabled cache. image

The progressbar's labels upflow and downflow have been changed to Upstream and Downstream in the new release. The screenshots have shown that you are not using the latest version. Thus, I'm very sure that there are something wrong in you side.

It is mostly likely that the your browser has not replaced these old cached *.js files.

sinancetinkaya commented 4 years ago

yeah they are changed now too image