search

brwyatt / puppet-flatpak

Puppet module for installing and managing Flatpak packages
https://forge.puppet.com/brwyatt/flatpak
GNU Lesser General Public License v3.0
6 stars 10 forks source link

Optional apt #11

Closed brwyatt closed 4 years ago

brwyatt commented 4 years ago

Building on top of #10, wanted to clean this up and make the support for RHEL a little more official.

In addition to @anarcat's changes, I've updated the tests and added in Hiera to automatically enable/disable repo management based on OS Family, and officially added CentOS/RHEL as supported, as per @traylenator's PR #8. I've also bumped the metadata.json version so when this is merged, a new version will get pushed to the Forge as well.

One final note: since the "dependencies" section is mostly just suggestions (and not checked or enforced at runtime), I've added the puppetlabs-apt dependency back in, so the version hints will remain. This shouldn't cause any issues for anyone not using (and not needing) the apt module (it shouldn't result in it getting installed, and even if it did, it shouldn't cause problems).

brwyatt commented 4 years ago

@anarcat and @traylenator -

I'm going to leave this PR open for about a week to get y'all's feedback, to make sure this works for the both of you. If it does, I'll go ahead and get this merged in and get a new version pushed up to the Forge.

Thanks to both of you for your PRs, commits, and suggestions so far on this!

traylenator commented 4 years ago

Thanks , for working in the updates. Looks good i'd say.