Use standard Java conventions

bryan-emmanuel / javageomodel

Automatically exported from code.google.com/p/javageomodel

0 stars 0 forks source link

Use standard Java conventions #2

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago

I'm currently using a custom library to use geospatial queries with the GAE, 
but I would really like to use your project.
My main problem are method/parameter names like "default_cost_function". I 
know this Library was ported from Python, but this is very uncommon in the 
Java world. Your would rather name the method "defaultCostFunction".
Could this please be refactored? I would gladly help improve this library 
instead of maintain my own implementation.

Original issue reported on code.google.com by mknit...@googlemail.com on 14 Mar 2010 at 5:05

GoogleCodeExporter commented 8 years ago

The truth is I wanted to thank the python guys for their work and keep the 
python
naming convention. But you're right, we should use Java convention.
Same comment as Issue 1, do whatever you feel right on this project since 
you're now
a commiter.

Original comment by alexandr...@gmail.com on 26 Mar 2010 at 3:01

GoogleCodeExporter commented 8 years ago

Commited.

Original comment by alexandr...@gmail.com on 10 Apr 2010 at 3:40

Changed state: Verified

GoogleCodeExporter commented 8 years ago

Adjusted the POM and directory structure. Also fixed the tests...

Original comment by mknit...@googlemail.com on 10 Apr 2010 at 4:15

GoogleCodeExporter commented 8 years ago

Ups, wrong ticket. This comment belongs to issue 1...

Original comment by mknit...@googlemail.com on 10 Apr 2010 at 6:23