search

bryan-emmanuel / javageomodel

Automatically exported from code.google.com/p/javageomodel
0 stars 0 forks source link

proximityFetch logic bug #6

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
This line from proximityFetch cannot be right.  If baseQuery.getBaseQuery()
returns null, the first part of the OR is false, and the second part is
then guaranteed to throw a NPE:

String and = baseQuery.getBaseQuery() != null ||
baseQuery.getBaseQuery().trim().length() == 0 ? " && " : " ";

Original issue reported on code.google.com by michael....@gmail.com on 20 Apr 2010 at 1:53

GoogleCodeExporter commented 8 years ago 
I think this patch makes the code behave more reasonably

Original comment by michael....@gmail.com on 20 Apr 2010 at 2:10

Attachments:

GoogleCodeExporter commented 8 years ago

Original comment by alexandr...@gmail.com on 10 Nov 2010 at 9:30