search

bryanbraun / middleman-navtree

For building navigation trees & menus in Middleman.
MIT License
45 stars 17 forks source link

adds directory index support #20

Closed meesterdude closed 6 years ago

meesterdude commented 7 years ago

Hello there,

I stumbled upon your gem the other night and noticed it didn't do directory indexes the way I would expect. So, I did some hacking and think i have the desired behavior. This should address issue #12

This is the structure i have: structure

so devices/ and computers/ have index files, but not projectors/

with directory_index disabled (existing behavior): disabled

With directory_index enabled (new behavior) enabled

I did some QA on my end and it seems to behave correctly. But please do give it look over and let me know!

bryanbraun commented 7 years ago

Hey thanks for giving this a look.

I'm having trouble getting this to work locally. I've enabled your config[:directory_index] = true

When I run it withactivate :directory_indexes, I only see folder names, and they aren't linked: image

When I run it withoutactivate :directory_indexes, I see the navtree, but the directories aren't linked like I'm expecting (and I do have index.html.md files in each folder):

image

I'm trying this on Middleman 4. Any idea what's going on?

Also, it looks like there are some conflicts in the PR

(Finally, since you are making some big contrinbutions, let me know if you are interested in maintaining this gem going forward :))

bryanbraun commented 6 years ago

I'm going to go ahead and close this since there's been no activity here for a while. Feel free to comment on https://github.com/bryanbraun/middleman-navtree/issues/12 if you want to discuss this feature some more.