search

bryanbraun / music-box-fun

A web app for making music box songs.
https://musicbox.fun
Other
53 stars 5 forks source link

Add new "Snap to" increments #12

Closed bryanbraun closed 3 years ago

bryanbraun commented 4 years ago

Currently we have a "snap to grid" feature. That's nice for songs with mostly quarter notes and eighth-notes.

I'd like to support other snap increments, including:

For the UI we'll want to decide between these two patterns:

  1. All options go in a dropdown (Snap to grid, snap to 16th, snap to triplets, and no snapping)
  2. A checkbox/toggle for enabling snapping, and a dropdown for the snap-increment (grid, 16th notes, and triplets).
    • We'd want to disable the dropdown element

I think 1. is simpler and cleaner, but 2. might be a better UX.

bryanbraun commented 3 years ago

Made huge progress on this today!

I went with option 1 above. It's so simple I'll actually have fewer lines of code than when I started!!

I just need to do some cross browser testing, and then I'll push it out.

bryanbraun commented 3 years ago

Merged in f840703.