search

bryanbraun / music-box-fun

A web app for making music box songs.
https://musicbox.fun
Other
53 stars 5 forks source link

Better navigation on mobile #8

Closed bryanbraun closed 3 years ago

bryanbraun commented 4 years ago

Currently, mobile users aren't able to see the content in either of the sidebars. To improve this lets try the following:

  1. [x] Move the "song updated message"
    • [x] We could create a "copy song link" button at the bottom left, which is where that "updated" flash can live going forward.
    • Alternatively, the notification area in the top-left could be moved to the top-center at mobile, and could include the "audio-disabled message," as well as the "song updated message."
  2. [x] Add the menu navigation
    • [x] Hamburger menu icon. Top left. Opens the left sidebar.
  3. [x] Add the controls navigation
    • [x] Gear icon. Top right. Opens the right sidebar.
  4. [x] Add more obvious close buttons to improve accessibility.

Reference the Material Navigation Drawer (including the one that the material.io website itself uses) for some basic open/close behaviors that feel pretty simple: https://material.io/develop/web/components/navigation-drawer

bryanbraun commented 3 years ago

Fixed in 6642ea7f93a3e641d7ac6be8dccc14c5df71225c.