[Bug] Extraneous escaping in `EventAttribute#json` - Githubissues

bryanchriswhite / pocketdex

Pocketdex is an indexer for the Shannon implementation of the pocket network protocol.

MIT License

0 stars 2 forks source link

[Bug] Extraneous escaping in `EventAttribute#json` #5

Closed bryanchriswhite closed 4 days ago

bryanchriswhite commented 5 days ago

Objective

Investigate the presence of extraneous JSON string escaping as seen below.
Enumerate effected entities may also be effected.
Understand and correct effected mapping handler functions.
Document best practices for serializing JSON in mapping handlers.

Origin Document

By contrast, Message#json properly escapes quotes in the JSON string with a single \:

Goals

Remove redundant escaping of entity fields
Mitigate future occurences by updating docs

Deliverables

[ ] One or more PR(s) that update effected mapping handler function(s)
[ ] A PR which adds a docs/best_practices.md which includes a `

Non-goals / Non-deliverables

Unrelated changes to the schema or mapping handlers outside the scope of addressing this issue.

General deliverables

[ ] Comments: Add/update TODOs and comments alongside the source code so it is easier to follow.

Creator: @bryanchriswhite Co-Owners: [sign up here!]

bryanchriswhite commented 4 days ago

Moved to https://github.com/pokt-network/pocketdex/issues/1