Specular artifact when directly facing very rough perpendicular surface.

bryanedds / Nu

Repository hosting the open-source Nu Game Engine and related projects.

MIT License

1.1k stars 155 forks source link

Specular artifact when directly facing very rough perpendicular surface. #640

Closed bryanedds closed 9 months ago

bryanedds commented 9 months ago

Since implementing the renderer, there's always been this specular artifact when directly facing rough surfaces -

I'm not sure if this is physically correct or if it's either an error or precision issue.

At a minimum, this should be understood.

bryanedds commented 9 months ago

Marking this as a bug.

bryanedds commented 9 months ago

Spent half a day taking a cursory look into this. Determined that we're probably going to have to dive deep back into understand PBR to be figure out how to fix or at least mitigate this issue.

bryanedds commented 9 months ago

As a quick resort, I decided to bisect and see if it was ever not there. So I bisected further, and found the issue was in 6d960903ba6c74cbf0c012714ecb8230a5dbe88a where I mindlessly turned the BRDF texture into filtered / mipped.