search

bryanedds / Nu

Repository hosting the open-source Nu Game Engine and related projects.
MIT License
1.12k stars 156 forks source link

See if there's a good reason why view matrices are being constructed via CreateLookAt instead of CreateFromTrs. #763

Open bryanedds opened 6 months ago

bryanedds commented 6 months ago

Currently we're doing like so in many places -

let eyeTarget = eyeCenter + Vector3.Transform (v3Forward, eyeRotation)
Matrix4x4.CreateLookAt (eyeCenter, eyeTarget, v3Up)

...but it seems it'd be preferable to do -

Matrix4x4.CreateFromTrs (eyeCenter, eyeRotation, v3One)

Seems like we'd lose some flexibility of use on the former.