search

bryanforbes / discord.py-stubs

discord.py stubs
BSD 3-Clause "New" or "Revised" License
46 stars 12 forks source link

Make abc.GuildChannel.move param reason be str #95

Closed PythonCoderAS closed 3 years ago

PythonCoderAS commented 3 years ago

Discord.py expects a string, not a boolean.

bryanforbes commented 3 years ago

It looks like discord.CategoryChannel.move() needs to have its signature updated as well

PythonCoderAS commented 3 years ago

I have a question: Why does CategoryChannel.move() have a category parameter as well? It doesn't make any sense to assign a category to a category.

bryanforbes commented 3 years ago

CategoryChannel.move() is required (type-wise) to take category so that it matches the signature of GuildChannel.move(). The code in CategoryChannel.move() discards any category passed in, but still accepts it as a parameter.