bryangrim / darkice

Automatically exported from code.google.com/p/darkice
0 stars 0 forks source link

--with-opus fails when Ogg files aren't together with Opus files #105

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
If Ogg Opus path and Ogg Vorbis path are different then configure fails to 
enable Opus.

What steps will reproduce the problem?
1. Place Opus and Ogg Vorbis libraries and includes in different directories. 
For instance, use the distro's Ogg Vorbis files with Opus files in /usr/local.
2. Run configure  --with-opus --with-opus-path=[PATH] --with-vorbis 
--with-vorbis-path=[PATH]
3. Observe that Opus get skipped.

What is the expected output? What do you see instead?
Opus libraries and includes are expected to be found. Instead they are not:

checking for vorbis libraries at /usr ... found at /usr 
checking for opus libraries at /usr/local ... configure: WARNING: not found, 
building without Ogg Opus

What version of the product are you using? On what operating system?
Darkice 1.2 on CentOS 6.5

Please provide any additional information below.

The Opus detection code in configure looks for Ogg files in the OPUS_LIB_LOC 
and OPUS_INC_LOC. These should instead be OGG_LIB_LOC and OGG_INC_LOC. A patch 
is included.

Also, Ogg should be a dependency of Opus. My patch doesn't do that but someone 
is welcome to add it.

Original issue reported on code.google.com by jmarktur...@gmail.com on 1 Mar 2014 at 1:50

Attachments:

GoogleCodeExporter commented 8 years ago
Correction: the patch changes OPUS_CONFIG_PREFIX to VORBIS_CONFIG_PREFIX in the 
Opus detection code of configure.

Original comment by jmarktur...@gmail.com on 1 Mar 2014 at 1:52