search

bryangrim / darkice

Automatically exported from code.google.com/p/darkice
0 stars 0 forks source link

Ogg Opus patch #75

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
New Feature

What is the expected output? What do you see instead?
Adds support for Ogg Opus to Icecast2.  Tested with resampling and cbr/abr 
modes.

What version of the product are you using? On what operating system?
Current SVN with Linux.

Please provide any additional information below.
http://opus-codec.org was released as an open codec, and is currently supported 
by Firefox and Icecast2.  This patch is designed to add basic Opus support to 
Darkice.  I've tested it with the released libopus and the current beta 
Icecast2 server, and everything appears to function normally.  It also works 
with the file output backend.

Original issue reported on code.google.com by dougk....@gmail.com on 20 Sep 2012 at 6:39

Attachments:

GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago 
Hmm, still a few bugs in this implementation--notably, stream segfaults on 
close, and it appears there are sampling issues (intermittent pops when 
streaming to icecast2, file output is distorted).  I'm still looking into these 
issues, though.

Original comment by dougk....@gmail.com on 21 Sep 2012 at 3:24

GoogleCodeExporter commented 8 years ago 
Clarification--stream only segfaults when using a file output.  Icecast2 output 
works properly and cleans up.  And a cleaned-up patch which addresses all 
(known) bugs is attached.

Original comment by dougk....@gmail.com on 22 Sep 2012 at 12:59

Attachments:

GoogleCodeExporter commented 8 years ago 
I'd like to try out opus because it supposedly has the ultra low latency 
features from CELT. Any progress on accepting this patch?

Original comment by kumar.mcmillan on 24 Mar 2013 at 11:06

GoogleCodeExporter commented 8 years ago 
I've not seen any movement on the patch, but I am following the issue.  I don't 
know how well it will work in any of the low-latency modes, since I tried to 
focus on high-quality audio more than the low-latency.  But, I can see how 
other modes may be useful, and I'd be interested in eventually adding these 
options to the configuration.

Original comment by dougk....@gmail.com on 24 Mar 2013 at 11:13

GoogleCodeExporter commented 8 years ago 
Are the problems still present? Should I apply the patch?

Original comment by rafael2k...@gmail.com on 14 May 2013 at 3:51

GoogleCodeExporter commented 8 years ago 
It's been a while, but as far as I know, everything is working in my patch, 
although it *does* have limitations (such as hard-coding the Opus 
complexity/signal type).  It should be a working starting point should people 
want to further enhance the support.  This is also something I wouldn't mind 
helping with/supporting, however I've been working on other projects recently.  
Better comment support, for example, would be one area I'd love to improve in 
the future (supporting sending new comment tags mid-stream to update remote 
players' titles).

Original comment by dougk....@gmail.com on 14 May 2013 at 4:00

GoogleCodeExporter commented 8 years ago 
Patch applied in r517 and r518.
Please check if it's everything fine.
Thanks!

Original comment by rafael2k...@gmail.com on 14 May 2013 at 5:35

GoogleCodeExporter commented 8 years ago 
Thanks, confirmed that it builds and runs.  The Opus developers are giving me 
some feedback for improvement, but for now, it seems to be working!

Original comment by dougk....@gmail.com on 14 May 2013 at 6:40