search

bryanhce / pe

0 stars 0 forks source link

Unfulfilled nonfunctional requirement #28

Open bryanhce opened 1 year ago

bryanhce commented 1 year ago

Screenshot 2022-11-11 at 5.31.32 PM.png

The fifth NFR about unauthorised users was not enforced, there was no security check or any type of validation done to check is the user is authorised.

nus-pe-bot commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

NFR 5 is not achieved.

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.

image.png

NFRs should be achieved already, however there are no authority rules in the app.

[original: nus-cs2103-AY2223S1/pe-interim#3049] [original labels: severity.Medium type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

We recognise this as an unfulfilled NFR and its clear the feature is doable with various encryption, password etc. Thus should be classified as a FeatureFlaw. However, this bug was reported during the Part II (Evaluating Documents) stage of the PE. Thus we will reject this bug as it is not related to the quality of documentation.

Screenshot 2022-11-14 at 3.19.35 PM.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: The reason for rejecting this bug is because this is a feature flaw and not a documentation bug. This is subjective as the team could simply remove the fifth NFR in the DG, making this a documentation bug as well. In addition, implementing the authorisation feature is unreasonable as it requires knowledge on encryption which is out of the scope of this application/ module. As such, this should be seen as a documentation bug rather than a feature flaw (even though it actually is both).

:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.DocumentationBug]

Reason for disagreement: This should be a documentation bug as implementing the authorisation feature is unreasonable as it requires knowledge on encryption which is out of the scope of this application/ module. Your time is better spent on improving your other features, and this NFR should have been left out of the DG or placed under features to implement in the future. As such, this should be seen as a documentation bug rather than a feature flaw.