bryanhce / pe

0 stars 0 forks source link

Bug in duplicate person detection when additional space between 2 names of person #3

Open bryanhce opened 1 year ago

bryanhce commented 1 year ago

Screenshot 2022-11-11 at 4.15.55 PM.png

The app should throw an error or a warning when "John Doe" is in the app and "John Doe" (with 2 spaces between) is a new person to add. They are likely the same person but because of a typo they could be added twice.

soc-se-bot commented 1 year ago

Team's Response

Added duplicate since both issues are considered similar under "duplication detection" as mentioned under course admin issue.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

User may input duplicate persons if there is an extra space in the name

edit 1 n/David Li

David Li already exists on the list (index 4). But if a user were to input the name 'David Li' with an extra space accidentally, it accepts the input. Extra white space is unlikely to mean that they are the same person.

Screenshot 2022-11-11 at 4.17.14 PM.png


[original: nus-cs2103-AY2223S1/pe-interim#1253] [original labels: type.FunctionalityBug severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

No details provided by team.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


:question: Issue type

Team chose [type.FunctionalityBug] Originally [type.FeatureFlaw]

Reason for disagreement: Screenshot 2022-11-15 at 12.49.43 PM.png

According to the textbook, bugs related duplicate is a feature flaw, not a functionality bug.


:question: Issue severity

Team chose [severity.Low] Originally [severity.VeryLow]

Reason for disagreement: [replace this with your explanation]