bryanhce / pe

0 stars 0 forks source link

Should not accept names that only contain numbers #5

Open bryanhce opened 1 year ago

bryanhce commented 1 year ago

Screenshot 2022-11-11 at 4.19.09 PM.png

The app should have shown a warning or an error when a name that contains only numbers like "123" is entered as this is not a real name.

nus-se-script commented 1 year ago

Team's Response

There are many names today that contains numbers, for example Jennifer 8. Lee

We also know what Elon decided to name his son. In all, we believe that if we were to restrict these names, it will be Overzealous input validation because who knows what someone is going to name their child next

Adding a specific method to check SPECIFICALLY whether a name contains only numerals is therefore unnecessary and not meaningful

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I agree that names do contain numbers but that is not a the point of the bug that I am reporting. This is also not overzealous input validation as names should not purely be numbers. Such names are simply not valid. Your email checking criteria is not considered overzealous, as seen in the chunk of text below, so how can you call having 1 more valid additional check on names being purely numbers, overzealous?

Screenshot 2022-11-15 at 12.59.11 PM.png

Fun info: Elon's son, X Æ A-Xii, cannot be added into your app because of the special character! There is also no numbers in his name.