search

bryanjhc / pe

0 stars 0 forks source link

EduContacts is for tertiary educators in Singapore but do not validate 8 digit phone numbers to start with only 6, 8 or 9 #4

Open bryanjhc opened 1 week ago

bryanjhc commented 1 week ago

Problem

As mentioned in User Guide, EduContacts is for tertiary educators in Singapore but do not validate 8 digit phone numbers which are Singaporean phone numbers to start with only 6, 8 or 9

Steps to reproduce

Using this command: add 93842083 n/Jon Ang e/JonAng@yahoomail.com p/73947098 c/mycourse r/student a/1234 Yishun Road, #13-24, Yishun View, Singapore 630234 The actual output will be as seen in the following image, where an 8 digit phone number that starts with 7 is accepted:

image.png

Expected

Maybe we could have tweaked it so that 8 digit phone numbers are only allowed to start with 6, 8 or 9 and warn the user otherwise so as to prevent mistakes made by mistyping the first number.

Severity Label Explanation

The chosen severity label is severity.low as this problem will only happen if the user mistypes the first number of the phone number accidentally, it will indeed cause an inconvenience to the teacher as the mistake could have been caught instead.

nus-se-bot commented 4 days ago

Team's Response

Duplicate of #3068.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Phone number field is not constrained enough given context of app's usage

Currently, the only constraints for the phone number field when adding contacts is that they must only contain numerical digits and be at least 8 digits long.

However, the specified target users of this app are educators in tertiary institutions in Singapore. With this given context, Singaporean phone numbers have more restrictions than just what is currently stated in the UG:

  • Singaporean personal phone numbers are exactly 8 digits long
  • Singaporean personal phone numbers can only start with the digit 8 or 9
  • For international students who might not have Singaporean phone numbers, tutors should be able to save their regional caller ID as well so that they are able to contact them. For example, the regional ID of Singapore is +65, and that of Malaysia is +60.

Hence the app should also warn users if they add a phone number violating these constraints so that they can check they are adding the correct phone number for their contacts.

Screenshot 1: specificTargetAudience.png

Screenshot 2: phoneNumberField.png

[original: nus-cs2103-AY2425S1/pe-interim#1605] [original labels: type.FeatureFlaw severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

This bug is accepted.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]