search

bryanljx / pe

0 stars 0 forks source link

Incorrect UML class diagram #11

Open bryanljx opened 1 year ago

bryanljx commented 1 year ago

In the Developer Guide, this is the UML diagram provided for Model.

image.png

However, it is missing certain important attributes such as GitHub and Telegram which are important features of the contacts provided in CodeConnect.

image.png

nus-pe-bot commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Missing classes in Class/Object Diagram

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.

Description:

Classes such as telegram or github seem to be missing from the class diagram. I'm not quite sure why it is omitted when the rest of the Person classes are inside the class diagram.

If your team is worried about the diagram being too big, you can create a separate class diagram for person itself! Nonetheless, it is not a huge inconvenience as I can easily see which classes person has after reading your UG and DG.

Screenshots:

image.png

[original: nus-cs2103-AY2223S1/pe-interim#3927] [original labels: severity.VeryLow type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

No details provided by team.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]