bryanlundberg / NexusTimer

Nexus Timer is a powerful unopinionated, minimalist training tool for SpeedCubing.
https://nexustimer.com/
GNU General Public License v3.0
42 stars 32 forks source link

Added feature for full screen #234

Closed RigvedRocks closed 10 months ago

RigvedRocks commented 10 months ago

What does this PR do? I have added the functionality for the full-screen feature as outlined in #202

Changes I have added the full-screen feature to the project. In this I have made modifications to the following files and folders - i) Added two new files in the Icon folder for full-screen and exit full-screen icons - FullScreen.tsx and ExitFullScreen.tsx ii) Made changes to the HeaderTimer.tsx iii) Create a new file named fullscreenStore.tsx in the store folder.

Screenshots or GIFs (if applicable) Screenshot (101) Screenshot (102)

By submitting this PR, I confirm that:

RigvedRocks commented 10 months ago

Thank you so much for the insights, bryanlundberg. Based on your suggestions, I have modified the code. Please have a look at the latest commit and suggest amendments if any. Screenshot (104) Screenshot (105)

RigvedRocks commented 10 months ago

@bryanlundberg Can you please guide me as to how I can just merge the hooks and icons. I am new to the field of open-source development. Sorry for the trouble. If you want to I can close this draft PR, and open a new one with the hooks and icons.

RigvedRocks commented 10 months ago

Closing this draft PR and opening a new one, merging the hook and icons along with changes to the timer component.