Feat/custom context menu

bryanlundberg / NexusTimer

Nexus Timer is a powerful unopinionated, minimalist training tool for SpeedCubing.

https://nexustimer.com/

GNU General Public License v3.0

42 stars 32 forks source link

Feat/custom context menu #316

Closed syrok94 closed 4 months ago

syrok94 commented 4 months ago

What does this PR do? fix #270, add a context menu as well as fix its position

Related Issue(s) none

Changes Added a ContextMenu.tsx file which can be reused to add a context menu

Screenshots or GIFs (if applicable)

Additional Comments none

By submitting this PR, I confirm that:

[x] I have reviewed my code and believe it is ready for merging.
[x] I understand that this PR may be subject to review and changes.
[x] I agree to abide by the code of conduct and contributing guidelines of this project.

syrok94 commented 4 months ago

Hi @bryanlundberg , will you please tell me the simplified way of doing this so that I can try it that way? also when I change it to dark mode the solveArea looks like this ...

bryanlundberg commented 4 months ago

Hey @syrok94 I carefully reviewed your implementation and it was fine. I helped you with some minor adjustments to the menu's positioning and styling, it was easier than explaining 😅

This feature looks ready to go, thanks for your work!

bryanlundberg commented 4 months ago

Preview

styled: Positioning / Colors / Size

https://github.com/bryanlundberg/NexusTimer/assets/119996547/3a756079-7229-4a3c-90b0-9dc622285cfe