search

bryanmylee / svelte-headless-table

Unopinionated and extensible data tables for Svelte
https://svelte-headless-table.bryanmylee.com/
478 stars 31 forks source link

Types now working with SvelteKit 2 #176

Closed ryanylee closed 9 months ago

ryanylee commented 9 months ago

Fixes https://github.com/bryanmylee/svelte-headless-table/issues/173

bryanmylee commented 9 months ago

Thanks @ryanylee and @AdrianGonz97! The PR helps a lot especially when I haven't had much time to work on this. Just a few issues to resolve, then I'll merge and make a major release update.

ryanylee commented 9 months ago

One thing to note is svelte-render needs to also be updated at some point, but the easy workaround for now in this PR is importing from the /createRender file rather than the root index.js

Thank you @AdrianGonz97 for the feedback!

bryanmylee commented 9 months ago

Updating SvelteKit to 2.x causes conflicts with our peer dependencies for Svelte 3.

Trying to update all my Svelte packages to keep up with SvelteKit has been an absolute shitshow of broken dependencies.

I'm going to spend a day just recreating the entire library along with all the dependent stuff, but this is ridiculous.

pheuter commented 9 months ago

It does appear that SvelteKit 2 intentionally drops support for Svelte 3:

We also recommend updating to Svelte 4 first: Later versions of SvelteKit 1.x support it, and SvelteKit 2.0 requires it.