search

bryansaylor / homework-portfolio

0 stars 0 forks source link

Feedback on assignment #2 #2

Open barryross opened 7 years ago

barryross commented 7 years ago

FEWD Week #2 Project: Styling with CSS

Description

A hot, new NY Tech Startup, Relaxr, has approached you to help them develop a new landing page for their company. They've handed you the design file for the site, along with the copy and assets. You need to take these files and turn it into a landing page.

Student: Bryan Saylor

Project URL: https://github.com/bryansaylor/homework-portfolio__
Technical Requirements Does Not Meet Expectations (0) Meets Expectations (1) Exceeds Expectations (2)
Use HTML5 structural elements (nav, header, footer) x
Use a CSS Reset file in addition to your style.css file to style the page x
Use IDs and Classes to to select and style elements on the page x
Style your text with the Google Fonts provided by your style guide x
Follow naming conventions, maintain consistency across .html and .css files and use best practices for naming IDs and Classes x
Indent nested elements to increase your code's readability x
TOTAL: 12/12
barryross commented 7 years ago

Bryan, excellent work on this! A couple suggestions in my inline comments, but overall this is looking great. Keep up the solid work! 👍