search

bryansaylor / homework-portfolio

0 stars 0 forks source link

Feedback on assignment #3 #3

Open barryross opened 7 years ago

barryross commented 7 years ago

FEWD Week #3 Project: CSS Layouts

Description

Relaxr was really impressed by your work last week and wants you to continue development on their landing page. Starting in class, you will work to build out a more complex layout for their company site. They decided on creating a blog, and their back-end engineers will be focused on developing the blog's functionality. They want your front-end skills to style their designs using HTML and CSS so Relaxr's engineers can begin integrating. Once again, the designers have handed you a basic design file with instructions and the JPEG below to help you bring the blog to life. Submit the finished version for homework.

Student: Bryan Saylor

Project URL:https://github.com/bryansaylor/homework-portfolio
Technical Requirements Does Not Meet Expectations (0) Meets Expectations (1) Exceeds Expectations (2)
Use in-line-block or floats in your CSS to achieve a two-column layout x
Use the correct Open Sans Google Font typeface to style the text denoted in the design file and according to the JPEG provided x
Use proper filename conventions (lowercase, .html) x
Use a single external CSS stylesheet to style all pages x
Use <img> tags for the headers of the posts x
Add a hover effect to all the links using pseudo-classes x
Integrate drop caps using pseudo-classes x
TOTAL: 11/14
barryross commented 7 years ago

Hey Bryan,

Overall, nice work on this assignment. You are doing some great things here. A few things I noticed..

You are very close to achieving the float layout...it's the margin-left and margin-right on the body that is causing some issues. You could resolve this by wrapping everything in a "container" div, and provide that with a fixed width and margin: 0 auto;.

Regarding the fonts...you are doing a great job matching the font-weight property...I just wasn't sure if the difference in font-size between your code and the design spec was intentional. Please let me know and if this was the case, I'm happy to adjust marks accordingly.

Lastly, I noticed that you have not leveraged the :hover pseudo-class. Please let me know if you have questions about this!

Great work with the float/clear portion and your selection of elements is great!

bryansaylor commented 7 years ago

Hey Barry,

Yeah the font-sizes were definitely adjusted by me after using the original values. In the future I'll include the originals commented out. Totally missed the :hover though, should have read more carefully.

barryross commented 7 years ago

Thanks for letting me know, and that sounds great about commenting out the originals in the future. Thanks, I'll go ahead and provide marks for the font sizes. Have a great weekend!