search

bryansaylor / homework-portfolio

0 stars 0 forks source link

Feedback on final project, milestone 2 #7

Open barryross opened 7 years ago

barryross commented 7 years ago

Hey Bryan, great start to this. Happy to see you are moving forward with the music blog idea! I see you have implemented the "read more"/"read less" functionality...great stuff! Have you thought about any additional jQuery or effects you may want to implement? How are you feeling about the project overall?

bryansaylor commented 7 years ago

There's definitely some more 'toggle' stuff i have planned, and I also want to shrink and lock the video upon scrolling, but after researching it a little it seems pretty involved. But hopefully i can find a decent solution

barryross commented 7 years ago

I think you are referring to having a fixed sidebar or footer or something that would contain the video...is that right?

Something like this?

https://css-tricks.com/examples/ScrollingSidebar/

bryansaylor commented 7 years ago

Yes, that would be great. The video is within the article at the top, but once it is out of view, i would love to do something like that.

On Fri, Apr 28, 2017 at 10:09 AM, Barry Ross notifications@github.com wrote:

I think you are referring to having a fixed sidebar or footer or something that would contain the video...is that right?

Something like this?

https://css-tricks.com/examples/ScrollingSidebar/

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/bryansaylor/homework-portfolio/issues/7#issuecomment-298054148, or mute the thread https://github.com/notifications/unsubscribe-auth/AIMCSrBjDdvN3Qgcqm_6ZdbMlg3-ykdUks5r0h1TgaJpZM4NJZpm .

barryross commented 7 years ago

I think it'd be a cool thing to implement too. Let me know if you would like a hand with how to approach it!