search

bryansaylor / homework-portfolio

0 stars 0 forks source link

Feedback on assignment #7 #8

Open barryross opened 7 years ago

barryross commented 7 years ago

FEWD Week #7 Project: Responsive Design

Description

Relaxr's user count has grown, and the number of users accessing the site from a mobile device has surprised everyone, even by today's standards. The product managers at Relaxr have asked you to return to the project and make their site responsive so it renders nicely on mobile devices. They had one of their internal developers make a few tweaks to your source code, and they have given you the new HTML / CSS files to work from. Using these starter files, build out the mobile layouts for the landing page and blog.

Student: Bryan Saylor

Project URL: https://github.com/bryansaylor/homework-portfolio
Technical Requirements Does Not Meet Expectations (0) Meets Expectations (1) Exceeds Expectations (2)
Use media queries at a 768px breakpoint x
Content remains in appropriate divs x
Content remains visible to the user x
Fonts change size appropriately x
Margins and padding change size appropriately x
Content does not overlap x
In the blog section, the two-column layout changes to a single-column layout when appropriate x
TOTAL: 13/14
barryross commented 7 years ago

Bryan, awesome work on this! This is looking great and I really appreciate how much effort/detail/attention you put into styling the mobile version 👏 .

Excellent job being aware of white space on mobile, and I'm pleased to see you centered the #sidebar content ! The only reason for the mark I left off was b/c I would encourage you provide some room for the post content to "breathe". So...I think some padding there would be in order and is important. I totally appreciate the other adjustments you made in terms of padding/margin. They did not go unnoticed!

Please see inline comments for details and keep up the great work!