Use `slice::iter` instead of `into_iter` to avoid future breakage

bryant / argon2rs

The pure-Rust password hashing library running on Argon2.

MIT License

174 stars 19 forks source link

Use `slice::iter` instead of `into_iter` to avoid future breakage #42

Closed LukasKalbertodt closed 4 years ago

LukasKalbertodt commented 4 years ago

an_array.into_iter() currently just works because of the autoref feature, which then calls <[T] as IntoIterator>::into_iter. But in the future, arrays will implement IntoIterator, too. In order to avoid problems in the future, the call is replaced by iter() which is shorter and more explicit.

A crater run showed that your crate is affected by a potential future change. See https://github.com/rust-lang/rust/pull/65819 for more information.

LukasKalbertodt commented 4 years ago

CI failure is not caused by this change as far as I can see.

LukasKalbertodt commented 4 years ago

Will close this PR to clean my "open PR" list.